Streaming Client Result investigation - assistants 2#49
Draft
annelo-msft wants to merge 17 commits intojoseharriaga:mainfrom
Draft
Streaming Client Result investigation - assistants 2#49annelo-msft wants to merge 17 commits intojoseharriaga:mainfrom
annelo-msft wants to merge 17 commits intojoseharriaga:mainfrom
Conversation
annelo-msft
changed the base branch from
main
to
user/traviw/streaming-assistants
annelo-msft
changed the base branch from
user/traviw/streaming-assistants
to
main
annelo-msft
commented
Mar 29, 2024
| PipelineResponse response = message.Response; | ||
| try | ||
| { | ||
| // TODO: dust this part up... |
annelo-msft
commented
Mar 29, 2024
|
|
||
| public async ValueTask<bool> MoveNextAsync() | ||
| { | ||
| // TODO: Can we wrap the boilerplate parts of this up into a special SSE base type for this? |
annelo-msft
commented
Mar 29, 2024
| // TODO: Revisit the IDisposable question | ||
| public abstract class StreamingClientResult<T> : ClientResult, IAsyncEnumerable<T> | ||
| // TODO: Note that constraining the T means the implementation can use | ||
| // ModelReaderWriter for deserialization. |
Collaborator
Author
There was a problem hiding this comment.
TODO: this is an important piece for a generalizable implementation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building on work by @trrwilson in #26 - primarily for prototyping and leaning